• cadekat
    link
    fedilink
    arrow-up
    9
    arrow-down
    2
    ·
    8 months ago

    Dependency injection is so much worse. Oh, hey, where’d this value come from? Giant blob of opaque reflection code.

    • Zagorath@aussie.zone
      link
      fedilink
      English
      arrow-up
      4
      ·
      8 months ago

      It can be used in bad ways, but if it’s used in the right way you should never have the situation you just described.

      • cadekat
        link
        fedilink
        arrow-up
        2
        arrow-down
        1
        ·
        8 months ago

        I’m not exactly sure what you mean. Doesn’t all dependency injection work the way I described?

        Without being familiar with the framework, you can’t trace your way from the class getting injected into to the configuration, even if you’re experienced with the language.

        • Zagorath@aussie.zone
          link
          fedilink
          English
          arrow-up
          2
          ·
          8 months ago

          I don’t think so. When I’ve seen it done it’s usually not been random values injected (except when those values are secret keys which should absolutely not be stored in code to begin with), it’s usually injecting a service. Another class, usually with a name that makes it easy to trace down. Like if you’re building an OrderService, that might take as a dependency an IProductService, which would have injected into it the class ProductService (personally, I don’t like the Hungarian notation that C# uses, but it’s a convention and my preference for sticking to strong conventions for the sake of consistency outweighs my distaste for Hungarian notation). That’s easy to find, and in fact your IDE can probably take you straight to it from the OrderService’s constructor.

          • cadekat
            link
            fedilink
            arrow-up
            1
            ·
            8 months ago

            I’m using value in the loosest sense, like how all objects are values.

            So now if you have three implementations of IProductService, how do you know which one is configured?

            • Zagorath@aussie.zone
              link
              fedilink
              English
              arrow-up
              1
              ·
              8 months ago

              It’s easy to imagine a hypothetical way that could lead to problems. But in all the code I’ve worked with, either that scenario is avoided entirely, or other context makes it absolutely clear which IProductService is being used.

      • grrgyle@slrpnk.net
        link
        fedilink
        arrow-up
        1
        ·
        8 months ago

        Same could be said of a global. There’s a time and a place for each.

        One thing I’ll say is I don’t remember us needing a team of senior+ devs to handle web app back in the day…